Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add FirstArgLossless supertype #20394

Merged
merged 1 commit into from
Dec 21, 2024
Merged

feat: Add FirstArgLossless supertype #20394

merged 1 commit into from
Dec 21, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 21, 2024
@ritchie46 ritchie46 merged commit dbd2c5f into main Dec 21, 2024
20 checks passed
@ritchie46 ritchie46 deleted the flags branch December 21, 2024 10:16
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 71.64179% with 19 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (5f791b4) to head (fd295ed).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/utils/supertype.rs 0.00% 9 Missing ⚠️
...ars-plan/src/plans/conversion/type_coercion/mod.rs 74.28% 9 Missing ⚠️
crates/polars-python/src/functions/misc.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20394      +/-   ##
==========================================
- Coverage   78.96%   78.95%   -0.01%     
==========================================
  Files        1561     1561              
  Lines      219871   219881      +10     
  Branches     2471     2471              
==========================================
- Hits       173611   173610       -1     
- Misses      45692    45703      +11     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants