Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Expose and rewrite 'can_pre_agg' #20450

Merged
merged 4 commits into from
Dec 26, 2024
Merged

refactor: Expose and rewrite 'can_pre_agg' #20450

merged 4 commits into from
Dec 26, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Dec 25, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (a6fffd4) to head (3e325ef).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/aexpr/utils.rs 98.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20450      +/-   ##
==========================================
- Coverage   79.00%   78.98%   -0.02%     
==========================================
  Files        1563     1563              
  Lines      220449   220557     +108     
  Branches     2488     2488              
==========================================
+ Hits       174157   174205      +48     
- Misses      45719    45779      +60     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 0c290d6 into main Dec 26, 2024
21 checks passed
@ritchie46 ritchie46 deleted the pre-agg branch December 26, 2024 19:21
@c-peters c-peters added the accepted Ready for implementation label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants