Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cat.contains and cat.contains_any #20582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcrumiller
Copy link
Contributor

Followup to #20257. Again, expression input patterns not allowed in cat.contains, only string inputs. For contains_any, expression inputs are allowed, because these are interpreted as a list of possible patterns.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (f104170) to head (7744eed).

Files with missing lines Patch % Lines
crates/polars-plan/src/dsl/function_expr/cat.rs 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20582      +/-   ##
==========================================
- Coverage   78.98%   78.98%   -0.01%     
==========================================
  Files        1564     1564              
  Lines      220765   220836      +71     
  Branches     2504     2504              
==========================================
+ Hits       174368   174422      +54     
- Misses      45823    45840      +17     
  Partials      574      574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant