Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default tab order for AnchorNav #622

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

joshfarrant
Copy link
Contributor

@joshfarrant joshfarrant commented Jun 24, 2024

Summary

Replace arrow key navigation with standard tab order navigation for the AnchorNav component.

What should reviewers focus on?

  • Ensure you can navigate through an AnchorNav using Tab and Shift + Tab keys

Steps to test:

  1. Open the AnchorNav component in Storybook
  2. Resize your viewport to see the mobile AnchorNav
  3. Use the Tab key to navigate through the links
  4. Use the Shift + Tab to navigate backwards

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

7852.mp4

Copy link

changeset-bot bot commented Jun 24, 2024

🦋 Changeset detected

Latest commit: 9acb271

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 24, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Jun 24, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@joshfarrant joshfarrant force-pushed the joshfarrant/a11y-7852 branch from c26bb06 to 7b40471 Compare June 24, 2024 13:51
@joshfarrant joshfarrant force-pushed the joshfarrant/a11y-7852 branch from 7b40471 to c5c736b Compare June 24, 2024 14:15
@joshfarrant joshfarrant marked this pull request as ready for review June 24, 2024 14:27
@joshfarrant joshfarrant requested a review from rezrah June 24, 2024 14:27
@joshfarrant joshfarrant force-pushed the joshfarrant/a11y-7852 branch from 678575b to 9acb271 Compare June 24, 2024 15:14
@joshfarrant joshfarrant requested a review from stamat June 25, 2024 10:41
Copy link
Contributor

@stamat stamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ✨ Great work of killing these customisations! We should also consifer shipping this #595 🙏

@joshfarrant joshfarrant merged commit 3450e4b into main Jun 25, 2024
17 checks passed
@joshfarrant joshfarrant deleted the joshfarrant/a11y-7852 branch June 25, 2024 13:33
@primer-css primer-css mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants