Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextInput, TextArea, and Select width bug #828

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

joshfarrant
Copy link
Contributor

@joshfarrant joshfarrant commented Nov 21, 2024

Summary

Fixes a bug where TextInput, TextArea, and Select components expand to the width of their parent FormControl's validation message.

Screen.sharing.-.2024-11-21.11_20_55.AM.mp4

List of notable changes:

  • Resolve bug in TextInput, TextArea, and Select components
  • Remove some redundant CSS from Select component

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: d410836

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 21, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Nov 21, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@joshfarrant joshfarrant force-pushed the joshfarrant/input-width-fix branch from 55f83f5 to 1903b39 Compare November 26, 2024 12:05
@joshfarrant joshfarrant changed the title Fix bug where TextInput width would expand to length of validation message Fix TextInput, TextArea, and Select width bug Nov 26, 2024
@joshfarrant joshfarrant requested a review from rezrah November 26, 2024 12:24
@joshfarrant joshfarrant marked this pull request as ready for review November 26, 2024 12:24
@joshfarrant joshfarrant force-pushed the joshfarrant/input-width-fix branch from 0d4ab3e to 57e079d Compare December 5, 2024 10:36
@joshfarrant joshfarrant force-pushed the joshfarrant/input-width-fix branch from 57e079d to 07c9a2f Compare December 5, 2024 12:05
@joshfarrant joshfarrant force-pushed the joshfarrant/input-width-fix branch from 07c9a2f to d410836 Compare December 5, 2024 12:45
Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✨

@joshfarrant joshfarrant merged commit 652e7ff into main Dec 5, 2024
18 checks passed
@joshfarrant joshfarrant deleted the joshfarrant/input-width-fix branch December 5, 2024 14:29
@primer-css primer-css mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants