-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VideoPlayer.Source examples in docs to use remote image #876
base: main
Are you sure you want to change the base?
Conversation
|
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- apps/docs/content/components/VideoPlayer.mdx: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
e55a6e4
to
da89a1c
Compare
@@ -17,7 +17,7 @@ import {VideoPlayer} from '@primer/react-brand' | |||
|
|||
```jsx live | |||
<VideoPlayer title="GitHub media player"> | |||
<VideoPlayer.Source src="/brand/assets/example.mp4" /> | |||
<VideoPlayer.Source src="https://github.com/primer/brand/raw/refs/heads/main/apps/storybook/static/example.mp4" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In hindsight this feels a little risky for a number of reasons....
Could we instead link directly to the origin URL, which should fix the issue by not appending a trailing slash.
<VideoPlayer.Source src="https://github.com/primer/brand/raw/refs/heads/main/apps/storybook/static/example.mp4" /> | |
<VideoPlayer.Source src="https://primer.github.io/brand/assets/example.mp4" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool, hadn't realised an absolute URL would fix it. Great suggestion, thanks!
Summary
The video examples in the docs aren't currently working. For some reason the
.mp4
isn't being served, so there's no video to play.This PR switches the src of the video to use the static version in the Primer Brand repo.
What should reviewers focus on?
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist: