Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special labels have low contrast within a .dropdown-item:hover #1498

Closed
mjacobus opened this issue Jul 13, 2021 · 0 comments · Fixed by #1499
Closed

Special labels have low contrast within a .dropdown-item:hover #1498

mjacobus opened this issue Jul 13, 2021 · 0 comments · Fixed by #1499

Comments

@mjacobus
Copy link
Contributor

mjacobus commented Jul 13, 2021

The current low contrast makes it very difficult to read some labels, such as in the example bellow

<details class="details-overlay details-reset position-relative d-inline-block float-right mr-3">
  <summary class="btn-link" role="button">
    Menu
  </summary>
  <details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-text-primary anim-scale-in width-auto" style="width: 185px" role="menu">
    <button type="button" class="dropdown-item btn-link" role="menuitem">
      Do Stuff
    </button>
    <div role="none" class="dropdown-divider"></div>
    <button class="dropdown-item btn-link">
      Beta Feature <span class="Label Label--success Label--inline mr-1 px-1">Beta</span>
    </button>
  </details-menu>
</details>

Regular vs :hover

Without hover
With hover

Same thing happens with other variations of beta labels. I.E. Label--warning.

Expected behavior

We probably want the label to inherit the color from the hovered item, in this case, white. The border color should probably be white too.

This PR solves a similar problem.

This issue was found while working in dotcom. I would be more than happy to pair with an expert in a fix. I assume the fix is simple, but my team and I currently lack the knowledge on how ship a css fix like this to dotcom.

mjacobus added a commit to mjacobus/css that referenced this issue Jul 13, 2021
simurai added a commit that referenced this issue Jul 15, 2021
* Fix label contrast (#1498)

* Update src/dropdown/dropdown.scss

Co-authored-by: simurai <[email protected]>

* Create two-cows-work.md

Co-authored-by: simurai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant