Update layout when the Counter is empty #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/9xkrp1pfr |
This was referenced Dec 13, 2022
This was referenced Dec 21, 2022
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
visibility:hiddenwithdisplay:nonefor empty Counter so that the layout is always optimal and consistent with the common usage of thehiddenhtml tag when its value is 0. To be considered also thatvisibility:hiddenworks as non-disruptive placeholder for the incoming amount only if it has 1 digit./cc @primer/ds-core
Revert https://github.com/github/github/pull/148773/commits/5138e844464f77549c8174d04eda83f9428d55ff once this is released.
Closes https://github.com/github/design-systems/issues/915