Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Color Modes #1131

Merged
merged 376 commits into from
Mar 10, 2021
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
376 commits
Select commit Hold shift + click to select a range
69d0242
add stylelint for header text color
Oct 15, 2020
6a2d378
npm install @primer/[email protected]
Oct 15, 2020
b414aea
npm instal @primer/[email protected]
Oct 15, 2020
1d259fb
remove stylelint line
Oct 15, 2020
db919ff
npm install @primer/[email protected]
Oct 15, 2020
3d63ade
fix linter
Oct 15, 2020
a68f5cc
fix linter
Oct 15, 2020
ccca4d5
fix linter
Oct 15, 2020
3cc5069
npm install @primer/[email protected]
Oct 15, 2020
07fd1da
npm install @primer/[email protected]
Oct 15, 2020
e246716
update variable for social count
Oct 15, 2020
2ddcdbc
npm install @primer/[email protected]
Oct 15, 2020
b8a4df5
Update autocomplete.scss
simurai Oct 16, 2020
7020fb0
Update avatar.scss
simurai Oct 16, 2020
b32e4f5
Update button.scss
simurai Oct 16, 2020
7609ed4
Update box.scss
simurai Oct 16, 2020
263f840
npm install @primer/[email protected]
simurai Oct 16, 2020
90eb064
npm install @primer/[email protected]
Oct 16, 2020
8057118
fix linter
Oct 16, 2020
61e175d
npm install @primer/[email protected]
Oct 16, 2020
9dbe7f9
npm install @primer/[email protected]
Oct 16, 2020
08c5da9
npm install @primer/[email protected]
Oct 16, 2020
1f7f08a
npm install @primer/[email protected]
Oct 16, 2020
c90ff75
fix linter
Oct 16, 2020
b2f1726
npm install @primer/[email protected]
Oct 16, 2020
9291c34
Prefix utilities with color-
simurai Oct 19, 2020
bd52907
Add functional labels
simurai Oct 19, 2020
e22b757
npm install @primer/[email protected]
Oct 19, 2020
01fd816
fix text color on dark mode for subnav and filter list
Oct 19, 2020
6d8e492
make disabled state input bg dark mode
Oct 19, 2020
c23bf4f
fix linter
Oct 19, 2020
f9c76a6
dropdown text color dark mode
Oct 19, 2020
5ecfb37
npm install @primer/[email protected]
simurai Oct 20, 2020
0283bae
Update Counter
simurai Oct 20, 2020
6ca6678
Update State
simurai Oct 20, 2020
1c4e71b
npm install @primer/[email protected]
simurai Oct 20, 2020
3cf2ad8
update underline-nav and flash colors
Oct 20, 2020
567085e
update underlinenav counter text color
Oct 20, 2020
9459592
npm install @primer/[email protected]
Oct 20, 2020
c5c9081
update underline-nav underline box shadow color
Oct 20, 2020
b32accf
Update autocomplete
simurai Oct 21, 2020
672c058
Update dropdown.scss
simurai Oct 21, 2020
0bdd5b8
Update select-menu.scss
simurai Oct 21, 2020
26a5523
Update branch-name.scss
simurai Oct 21, 2020
4b51635
Update breadcrumb.scss
simurai Oct 21, 2020
b7701ea
Update blankslate.scss
simurai Oct 21, 2020
d42a677
Update navigation
simurai Oct 21, 2020
82126ce
Add transition to tabnav
simurai Oct 21, 2020
f365362
Update pagination.scss
simurai Oct 21, 2020
c48cfdf
npm install @primer/[email protected]
simurai Oct 21, 2020
65b168b
Lint
simurai Oct 21, 2020
326b191
Remove unused rule
simurai Oct 21, 2020
b90a667
update form colors
Oct 21, 2020
fdd9051
Update form-control
simurai Oct 22, 2020
8c9b356
Update form validation
simurai Oct 22, 2020
3773ee1
Update links
simurai Oct 22, 2020
6e5d77b
Update MIGRATING.md
simurai Oct 22, 2020
7f7556c
npm install @primer/[email protected]
simurai Oct 22, 2020
bcb89ef
Fix focus variables
simurai Oct 22, 2020
93b2eab
npm install @primer/[email protected]
Oct 22, 2020
a7c192e
Update Primer Primitives, use new color mode mixins
BinaryMuse Oct 22, 2020
19c9d7e
:shirt: Fix lint errors
BinaryMuse Oct 22, 2020
34b65ae
resolve conflicts
Oct 22, 2020
66db006
npm install @primer/[email protected]
Oct 22, 2020
e04f6d2
npm install @primer/[email protected]
Oct 22, 2020
7a37503
lint fix
Oct 22, 2020
76762cb
update condensed timeline badge icon color
Oct 22, 2020
9325c99
update timeline line color
Oct 22, 2020
aecbc2c
update diffstat block colors + npm install @primer/[email protected]
Oct 22, 2020
ad82b6d
update diffstat block colors
Oct 22, 2020
a030797
npm install @primer/[email protected]
Oct 22, 2020
b89cac2
fix diffstat
Oct 22, 2020
b03b52b
Update color mode mixin to support 'auto'
BinaryMuse Oct 23, 2020
c3c0776
Remove data-color-mode selector on :root
BinaryMuse Oct 23, 2020
2372b00
Update outline + danger button
simurai Oct 23, 2020
21a6298
npm install @primer/[email protected]
simurai Oct 23, 2020
33cd1be
npm install @primer/[email protected]
Oct 23, 2020
db87377
npm install @primer/[email protected]
Oct 23, 2020
91f4a31
Update index.md
simurai Oct 24, 2020
edae9c3
WIP: Update buttons
simurai Oct 24, 2020
12e4983
Update button.scss
simurai Oct 24, 2020
051724a
Update primary button
simurai Oct 24, 2020
162b0b2
Update buttons.md
simurai Oct 26, 2020
08f5801
Fix close-button
simurai Oct 26, 2020
f303320
npm install @primer/[email protected]
simurai Oct 26, 2020
cb88290
Lint
simurai Oct 26, 2020
1a722f7
Use --color-border-secondary for Box-row dividers
simurai Oct 26, 2020
901868d
npm install @primer/[email protected]
simurai Oct 26, 2020
fedb8bd
npm install @primer/[email protected]
Oct 26, 2020
0e1b225
update merge box warning icon bg
Oct 26, 2020
168cdcc
npm install @primer/[email protected]
Oct 26, 2020
6d730b6
npm install @primer/[email protected]
Oct 26, 2020
9f81295
npm install @primer/[email protected]
Oct 26, 2020
a75f293
Add mixin for defining CSS variables with color mode coverage
BinaryMuse Oct 26, 2020
79844b9
Rename diff to diffstat
simurai Oct 27, 2020
c318edb
npm install @primer/[email protected]
Oct 27, 2020
bf52585
update diffstat colors to user correct functional name
Oct 27, 2020
dfa316c
npm install @primer/[email protected]
Oct 27, 2020
0396b9b
Merge branch 'mkt/color-modes-whee' of https://github.com/primer/css …
simurai Oct 28, 2020
378ccd8
update filter dropdown button text color
Oct 28, 2020
8093736
add success state ofr timeline item
Oct 28, 2020
2a0a09c
linter
Oct 28, 2020
fe10c22
linter
Oct 28, 2020
d20f865
Add color-text-white
simurai Oct 29, 2020
7dfc062
npm install @primer/[email protected]
simurai Oct 29, 2020
a92fa83
npm install @primer/[email protected]
Oct 29, 2020
b7eef5a
Changed autocomplete variables
auareyou Oct 29, 2020
d648179
npm install @primer/[email protected]
Oct 29, 2020
225b2c1
Generalize styles for overlay components
auareyou Oct 29, 2020
d1f3e78
npm install @primer/[email protected]
Oct 29, 2020
3a16720
Update suggester.scss
simurai Oct 30, 2020
515177f
Update select-menu.scss
simurai Oct 30, 2020
a498fb6
npm install @primer/[email protected]
Oct 30, 2020
a58ee74
npm install @primer/[email protected]
Oct 30, 2020
daf706d
npm install @primer/[email protected]
Oct 30, 2020
ce69a37
update menu selected state bg
Oct 30, 2020
d78d83a
fix linter, update underlinenav dark hover text
Oct 30, 2020
e1dfa6f
update hr color
Oct 30, 2020
40ef190
Merge branch 'mkt/color-modes-whee' into au-tocomplete-var
simurai Nov 2, 2020
3ea4d28
Use bg-overlay for Popovers
simurai Nov 2, 2020
84209ba
Merge pull request #1188 from primer/au-tocomplete-var
simurai Nov 2, 2020
ca18ab7
Update utilites
simurai Nov 2, 2020
2c089ff
Thanks linter
simurai Nov 2, 2020
714c3a5
npm install @primer/[email protected]
Nov 2, 2020
f35b9f0
npm install @primer/[email protected]
Nov 2, 2020
29f69aa
npm install @primer/[email protected]
Nov 3, 2020
20567ce
npm install @primer/[email protected]
Nov 3, 2020
e0bb3e6
npm install @primer/[email protected]
Nov 3, 2020
48d7ce5
npm install @primer/[email protected]
Nov 4, 2020
59a8516
Make .flash-full + .flash-banner have an opaque background
simurai Nov 5, 2020
204f639
Style Toasts in dark mode
simurai Nov 5, 2020
248e95a
Lint
simurai Nov 5, 2020
c54a2dd
update subhead border bottom to border secondary
Nov 5, 2020
20d54c5
update hr border color
Nov 5, 2020
d764f40
npm install @primer/[email protected]
simurai Nov 6, 2020
7a66f04
update yellow label styling to warning
Nov 9, 2020
2ec76c8
Bump primer/primitives
colebemis Nov 10, 2020
74b0a6e
npm install @primer/[email protected]
simurai Nov 10, 2020
901aca4
npm install @primer/[email protected]
simurai Nov 10, 2020
afea54d
Bump @primer/primitives
colebemis Nov 10, 2020
92786cc
Bump @primer/primitives
colebemis Nov 10, 2020
7eb3d52
npm install @primer/[email protected]
simurai Nov 11, 2020
eee7558
Fix right AvatarStack
simurai Nov 13, 2020
543302e
npm install @primer/[email protected]
simurai Nov 17, 2020
0a59f53
Merge branch 'master' into mkt/color-modes-whee
Nov 17, 2020
32990d3
npm install @primer/[email protected]
Nov 17, 2020
dbb8dc5
Replace --color-tabnav-selected-bg with --color-bg-canvas
simurai Nov 18, 2020
c5b66fb
Remove background for .write-content
simurai Nov 18, 2020
1e9ffb0
npm install @primer/[email protected]
simurai Nov 18, 2020
524fe69
npm install @primer/[email protected]
Nov 18, 2020
ab17094
npm install @primer/[email protected]
Nov 18, 2020
83a6a81
Remove 16.0.0
simurai Nov 19, 2020
eaa0450
Update labels
simurai Nov 19, 2020
299b8d8
npm install @primer/[email protected]
Nov 19, 2020
5c39e22
fix subnav and filter list component selected bg colors
Nov 19, 2020
c781839
Replace tooltip colors
simurai Nov 23, 2020
b2b5a01
Merge branch 'mkt/color-modes-whee' of https://github.com/primer/css …
simurai Nov 23, 2020
431d9a0
npm install @primer/[email protected]
simurai Nov 23, 2020
b679eea
update underline nav primary counter color
Nov 23, 2020
da2c4ee
linter
Nov 23, 2020
96246c7
fix nested class
Nov 23, 2020
b828ffe
Update form select icon
colebemis Nov 24, 2020
a0ccb27
Use double quotes to fix linting error
colebemis Nov 24, 2020
f623e6a
npm install @primer/[email protected]
simurai Nov 25, 2020
f4c2f7f
npm install @primer/[email protected]
simurai Nov 25, 2020
494b873
npm install @primer/[email protected]
simurai Nov 27, 2020
c5cfc9c
Fix transparent avatars
simurai Nov 30, 2020
d27e142
npm install @primer/[email protected]
simurai Nov 30, 2020
bdc300d
npm install @primer/[email protected]
simurai Dec 1, 2020
bcf157d
npm install @primer/[email protected]
Dec 1, 2020
b1e6255
Revert "npm install @primer/[email protected]"
Dec 1, 2020
9ecb135
npm install @primer/[email protected]
simurai Dec 2, 2020
4ed1d12
Enable color-scheme for auto mode
simurai Dec 4, 2020
09bf4d4
npm install @primer/[email protected]
Dec 4, 2020
4cb151a
Revert "npm install @primer/[email protected]"
BinaryMuse Dec 4, 2020
267474d
npm i @primer/[email protected]
BinaryMuse Dec 4, 2020
7d7aa0d
update button group to work for embedded btn
Dec 4, 2020
7800b41
lol nvm
Dec 4, 2020
4c7d66e
npm install @primer/[email protected]
Dec 4, 2020
136bb9f
update label darker to use gray-1
Dec 9, 2020
04e48c9
linter
Dec 9, 2020
93368c2
remove bg color from disabled invisible button
Dec 9, 2020
eefaa9f
rounded corners on box-footer
Dec 11, 2020
936e561
Enable dark mode colors
BinaryMuse Dec 14, 2020
98268ae
Experiments with dimmed
BinaryMuse Dec 14, 2020
a1a019b
Update primitives
BinaryMuse Dec 14, 2020
eae67f5
Revert to old color-mode mixin
BinaryMuse Dec 14, 2020
f0f0941
npm install @primer/[email protected]
Dec 15, 2020
dc67077
Merge branch 'mkt/dimmed' into mkt/color-modes-whee
BinaryMuse Dec 15, 2020
2385394
btn danger icons + npm install @primer/[email protected]
Dec 15, 2020
7f4651b
linter
Dec 15, 2020
458a2c5
Support any theme in any color mode, even auto
BinaryMuse Dec 15, 2020
0889e4b
Fix opposite-color-mode usage
BinaryMuse Dec 15, 2020
3e14f37
Make themes work correctly in opposite mode
BinaryMuse Dec 15, 2020
29169b4
Simplify color mode theme definition
BinaryMuse Dec 15, 2020
b3d1fb5
npm install @primer/[email protected]
Dec 16, 2020
d3fe0b7
npm install @primer/[email protected]
Dec 17, 2020
3ece05e
npm install @primer/[email protected]
simurai Dec 22, 2020
4964815
npm install @primer/[email protected]
simurai Dec 23, 2020
fd61f77
npm install @primer/primitives@canary
simurai Jan 6, 2021
0765a97
Move `border-bottom-color` transition into `:hover`
koddsson Jan 18, 2021
24b6cb8
Merge branch 'master' into mkt/color-modes-whee
simurai Jan 19, 2021
b59edf5
Merge branch 'master' into mkt/color-modes-whee
simurai Jan 19, 2021
e618b1e
npm install @primer/[email protected]
simurai Jan 19, 2021
99ffa56
Change transition for navigation items
koddsson Jan 19, 2021
7de8ebf
Merge branch 'mkt/color-modes-whee' into fix-underline-border-flash
koddsson Jan 19, 2021
71988b5
Make border style transparent
koddsson Jan 19, 2021
b9b041c
Merge pull request #1217 from primer/fix-underline-border-flash
simurai Jan 19, 2021
8ff9a1d
make disabled text for inputs easier to see
Jan 19, 2021
6a1daf3
npm install @primer/[email protected]
simurai Feb 3, 2021
6d5ef60
Replace rgba colors for marketing styles
simurai Feb 3, 2021
d48ebbb
Fix docs
simurai Feb 3, 2021
53e31bf
Update dark dimmed theme
BinaryMuse Feb 3, 2021
4da8818
Fix dark dimmed import path
BinaryMuse Feb 3, 2021
e6d203b
Use --color-icon-tertiary when disabled
simurai Feb 5, 2021
c8f900f
Add lint ignore for icon color
BinaryMuse Feb 5, 2021
5813a09
npm install @primer/[email protected]
simurai Feb 12, 2021
cd5cdf0
npm install @primer/[email protected]
simurai Feb 12, 2021
9ec838a
Use primitives variables for marketing buttons
simurai Feb 12, 2021
e213635
Add marketing functional variables
simurai Feb 12, 2021
20b1130
Lint
simurai Feb 12, 2021
9309c57
Add shadow colors
simurai Feb 24, 2021
e3d82fb
Remove dark dropdown
simurai Feb 26, 2021
ebdc346
npm install @primer/[email protected]
simurai Mar 1, 2021
b417b49
Updating the mixins that register the color modes
jonrohan Mar 3, 2021
60966e5
lint update
jonrohan Mar 3, 2021
06f28bc
more lint
jonrohan Mar 3, 2021
351d5e8
npm install @primer/[email protected]
simurai Mar 3, 2021
4862832
Use node 14.15.2 version
simurai Mar 3, 2021
afcbe60
Merge pull request #1231 from primer/mixin_updates
jonrohan Mar 3, 2021
434a935
Use --color-text-white for input-dark
simurai Mar 4, 2021
b3bc735
Comment out some presentational variables and utilities
simurai Mar 4, 2021
799d9b3
Remove presentational utilities/variables
simurai Mar 4, 2021
89d022b
Merge pull request #1233 from primer/color_modes/deprecate
simurai Mar 4, 2021
376e0d4
Put back some utilities for view_components
jonrohan Mar 4, 2021
09bea8d
lint fixes
jonrohan Mar 4, 2021
7e7b125
Merge pull request #1234 from primer/put_back_some_utilities
jonrohan Mar 4, 2021
50c2f03
Remove all deprecated colors
simurai Mar 5, 2021
e09aa8a
Keep .text-inherit
simurai Mar 5, 2021
b621594
Add warning about using latest version
simurai Mar 8, 2021
990b1f7
Remove labels
simurai Mar 8, 2021
fe6c4ef
Remove .box-shadow
simurai Mar 8, 2021
f1da379
Remove presentational .State classes
simurai Mar 8, 2021
65bb96f
Remove presentational .Counter classes
simurai Mar 8, 2021
08de943
Remove .input-dark
simurai Mar 8, 2021
474f27f
Merge pull request #1235 from primer/color_modes/remove-deprecated-co…
jonrohan Mar 8, 2021
bee4af7
Merge branch 'mkt/color-modes-whee' of https://github.com/primer/css …
simurai Mar 9, 2021
6e36291
Merge branch 'master' into mkt/color-modes-whee
simurai Mar 9, 2021
2772952
npm install
simurai Mar 9, 2021
f325e12
Merge branch 'release-16.0.0' into mkt/color-modes-whee
simurai Mar 10, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 73 additions & 75 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 9 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,16 @@
"test-migrate": "script/test-migrate"
},
"dependencies": {
"@primer/octicons": "^9.1.1"
"@primer/octicons": "^9.1.1",
"@primer/primitives": "0.0.0-18b6150"
},
"devDependencies": {
"@octokit/rest": "^16.34.0",
"@storybook/addon-viewport": "5.3.18",
"@storybook/react": "5.3.18",
"autoprefixer": "9.4.7",
"autoprefixer": "9.8.6",
"code-blocks": "^1.1.0",
"colorette": "^1.1.0",
"colorette": "^1.2.1",
"css-loader": "1.0.0",
"cssstats": "3.3.0",
"details-dialog-element": "^1.4.0",
Expand All @@ -62,13 +63,13 @@
"minimist": "1.2.3",
"node-fetch": "2.4.0",
"npm-run-all": "4.1.5",
"postcss": "7.0.14",
"postcss": "7.0.32",
"postcss-import": "^12.0.1",
"postcss-load-config": "2.0.0",
"postcss-loader": "^2.0.6",
"postcss-load-config": "2.1.0",
"postcss-loader": "^3.0.0",
"postcss-node-sass": "2.1.8",
"postcss-scss": "2.0.0",
"postcss-value-parser": "^4.0.2",
"postcss-scss": "2.1.1",
"postcss-value-parser": "^4.1.0",
"prop-types": "^15.6.2",
"semantic-release": "^15.13.27",
"semver": "5.7.1",
Expand Down
4 changes: 3 additions & 1 deletion postcss.config.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
const path = require('path')

module.exports = {
parser: 'postcss-scss',
map: {
Expand All @@ -6,7 +8,7 @@ module.exports = {
},
plugins: {
'postcss-node-sass': {
includePaths: ['node_modules'],
includePaths: [path.join(__dirname, 'node_modules')],
outputStyle: 'compressed'
},
'autoprefixer': {}
Expand Down
16 changes: 8 additions & 8 deletions script/dist.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ if (require.main === module) {
}

function writeVariableData() {
const analyzeVariables = require('./analyze-variables')
return Promise.all([
analyzeVariables('src/support/index.scss'),
analyzeVariables('src/marketing/support/index.scss')
]).then(([support, marketing]) => {
const data = Object.assign({}, support, marketing)
writeFile(join(outDir, 'variables.json'), JSON.stringify(data, null, 2))
})
// const analyzeVariables = require('./analyze-variables')
// return Promise.all([
// analyzeVariables('src/support/index.scss'),
// analyzeVariables('src/marketing/support/index.scss')
// ]).then(([support, marketing]) => {
// const data = Object.assign({}, support, marketing)
// writeFile(join(outDir, 'variables.json'), JSON.stringify(data, null, 2))
// })
}
28 changes: 14 additions & 14 deletions src/alerts/flash.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
position: relative;
// stylelint-disable-next-line primer/spacing
padding: 20px $spacer-3;
color: $text-gray-dark;
color: var(--text-primary);
border-style: $border-style;
border-width: $border-width;
border-radius: $border-radius;
Expand Down Expand Up @@ -66,48 +66,48 @@

.flash {
// stylelint-disable-next-line primer/colors
background-color: $blue-100;
background-color: var(--alert-bg);
// stylelint-disable-next-line primer/borders
border-color: rgba($blue-700, 0.2);
border-color: var(--alert-border);

.octicon {
// stylelint-disable-next-line primer/colors
color: rgba($blue-700, 0.6);
color: var(--alert-icon);
}
}

.flash-warn {
// stylelint-disable-next-line primer/colors
background-color: $yellow-100;
background-color: var(--alert-warn-bg);
// stylelint-disable-next-line primer/borders
border-color: rgba($yellow-800, 0.2);
border-color: var(--alert-warn-border);

.octicon {
// stylelint-disable-next-line primer/colors
color: rgba($yellow-800, 1);
color: var(--alert-warn-icon);
}
}

.flash-error {
// stylelint-disable-next-line primer/colors
background-color: #ffe3e6; // custom red
background-color: var(--alert-error-bg);
// stylelint-disable-next-line primer/borders
border-color: rgba($red-800, 0.2);
border-color: var(--alert-error-border);

.octicon {
// stylelint-disable-next-line primer/colors
color: rgba($red-800, 0.6);
color: var(--alert-error-icon);
}
}

.flash-success {
background-color: $bg-green-light;
background-color: var(--alert-success-bg);
// stylelint-disable-next-line primer/borders
border-color: rgba($green-700, 0.2);
border-color: var(--alert-success-border);

.octicon {
// stylelint-disable-next-line primer/colors
color: rgba($green-700, 0.8);
color: var(--alert-success-icon);
}
}

Expand Down Expand Up @@ -141,5 +141,5 @@
margin-bottom: 0.8em;
font-weight: $font-weight-bold;
// stylelint-disable-next-line primer/colors
background-color: $yellow-100;
background-color: var(--alert-warn-bg);
}
Loading