Make final position responsive #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/9fik6p6wa |
simurai
requested review from
jonrohan,
a team,
emilybrick and
colinkeany
and removed request for
a team and
emilybrick
jonrohan
approved these changes
Sep 10, 2020
|
Just noticed that Something we should look into fixing. Maybe remove |
This was referenced Dec 19, 2022
This was referenced Jan 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the "final position" utilities (
[top/left/right/bottom]-0) responsive (e.g.right-md-0,bottom-lg-0). This can be handy when moving select menus, dropdowns, popovers etc. around for certain responsive breakpoints. This came up in https://github.com/github/github/pull/153189.It also adds an option to "reset" a final position (e.g.
right-0 right-md-auto)./cc @primer/ds-core