-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 last minute tweaks #1615
V2 last minute tweaks #1615
Conversation
🦋 Changeset detectedLatest commit: bab09f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The history seems to be:
Maybe we should change that in primitives too, even though the variables already changed on dotcom https://github.com/github/github/pull/192360. Here a screenshot from v16: |
This makes the following changes to the deprecated/migration guide:
Replace
.color-border-tertiary
Depends a bit on primer/primitives#242.
Replace
.color-text-tertiary
Can't remember if that was intentional or just an oversight. But it seems that Primitives uses
"text.tertiary": "fg.muted",
. So maybe better to keep it the same for the utilities.