-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add styling for readonly
, fix AutoComplete inset focus background color
#2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Bailey <[email protected]>
🦋 Changeset detectedLatest commit: 514d29b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ericwbailey
changed the title
WIP
Add styling for Aug 26, 2022
readonly
, fix AutoComplete inset focus background color
jonrohan
approved these changes
Aug 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Eric Bailey [email protected]
What are you trying to accomplish?
This pull request addresses issues https://github.com/github/primer/issues/1230 and https://github.com/github/primer/issues/1208. It:
input
,select
, andtextarea
elements if areadonly
attribute is applied to it.readonly
support to Storybook.What approach did you choose and why?
readonly
We added a
readonly
attribute selector scoped to the.FormControl-input,
.FormControl-select
, and.FormControl-textarea
selector grouping. This scopes it to only Primer-related inputs, matching the treatment approach we use for thedisabled
attribute.We also added logic for Storybook to let it display the
readonly
attribute, if toggled.AutoComplete focus background color
We added a
:focus-visible
and:focus
selector grouping to.FormControl-inset
to adjust the background color to use--color-canvas-default
on the input's background, matching the treatment used on other Primer inputs.What should reviewers focus on?
Are the declarations applied to the most relevant selector set?
Can these changes ship as is?
Yes.