-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .break-word, improve word-break docs #880
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-wb-break-word.primer.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ 🙇♀
100c2a1
to
3baa3ee
Compare
FYI @emilybrick I've confirmed that the |
Okay @emilybrick, I think this is ready to review now. It's probably easiest to just look at the deployed docs and make sure that they make sense: |
The
break-word
class applies bothword-break: break-word
andoverflow-wrap: break-word
, to account for differences in the interpretation ofword-break
between Chrome and Firefox. See css-tricks for more info:My understanding is that Chrome's interpretation is "looser", in the sense that it breaks words regardless of language; while Firefox's interpretation is more strict, essentially requiring
overflow-wrap: break-word
for English text.Add.wb-break-word
declaration.break-word
declarationoverflow-wrap: break-word !important