Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SelectMenu docs #923

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Improve SelectMenu docs #923

merged 2 commits into from
Oct 1, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 1, 2019

This removes type="button" and aria-expanded="true" from .SelectMenu documentation.

Fixes that <summary> with type="button" reset the styling on mobile. Reported in Slack.

@vercel
Copy link

vercel bot commented Oct 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-select-menu-docs.primer.now.sh

@simurai simurai changed the title Update SelectMenu docs Improve SelectMenu docs Oct 1, 2019
@simurai simurai mentioned this pull request Oct 1, 2019
10 tasks
@shawnbot shawnbot changed the base branch from master to release-13.0.2 October 1, 2019 05:30
@shawnbot shawnbot merged commit 839437c into release-13.0.2 Oct 1, 2019
@shawnbot shawnbot deleted the select-menu-docs branch October 1, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants