Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint update #968

Merged
merged 37 commits into from
Nov 4, 2019
Merged

Stylelint update #968

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
ab379c9
bump stylelint-config-primer@9, install stylelint-only
shawnbot Oct 31, 2019
66436c6
enable primer/colors in stylelint.config.js
shawnbot Oct 31, 2019
49d1196
autofix primer/colors
shawnbot Oct 31, 2019
34c9665
$white + $black -> $text-<color>
shawnbot Oct 31, 2019
323bc8c
add $bg-black, $bg-black-fade, $text-white, $text-black, and $border-…
shawnbot Oct 31, 2019
13b4847
move $black and $white to the top
shawnbot Oct 31, 2019
72e012e
use $bg-black-fade instead of $black-fade-50
shawnbot Oct 31, 2019
121b850
install stylelint-disable
shawnbot Oct 31, 2019
d350d4b
break up background properties in <select> + status indicators (spinn…
shawnbot Oct 31, 2019
c46c7d1
add stylelint-disable comments for primer/colors
shawnbot Oct 31, 2019
b52a7aa
enable primer/borders
shawnbot Oct 31, 2019
6af4ab1
npx stylelint-only primer/borders -- --fix src
shawnbot Oct 31, 2019
6559cb3
npx stylelint-disable primer/borders -- src
shawnbot Oct 31, 2019
009705d
autofix + disable primer/spacing
shawnbot Oct 31, 2019
4d5b4c6
autofix some font-weight values
shawnbot Oct 31, 2019
263dc4f
enable primer/typography
shawnbot Oct 31, 2019
f425cd6
fix errant empty line
shawnbot Oct 31, 2019
268c384
add stylelint-disable comments for primer/typography
shawnbot Oct 31, 2019
fef6e91
enable primer/box-shadow
shawnbot Oct 31, 2019
4ac0c7f
add stylelint-disabl comments for primer/box-shadow
shawnbot Oct 31, 2019
9df0fb8
add !default to $tooltip-background-color
shawnbot Oct 31, 2019
b2e1f74
use $bg-black and $text-black in tooltips
shawnbot Oct 31, 2019
7fd97bf
move grays up, add $border-color-button
shawnbot Oct 31, 2019
c5c4f15
transparentize($black, 0.8) -> $border-color-button
shawnbot Oct 31, 2019
71171fb
nix needless disables
shawnbot Oct 31, 2019
5762d95
use rgba() instead of transparentize() for $repo-private-icon
shawnbot Oct 31, 2019
f91cf59
add !default to $border-color-button
shawnbot Oct 31, 2019
a77bcc0
add !default to $highlight-yellow
shawnbot Oct 31, 2019
d936b3a
install stylelint-scss
shawnbot Oct 31, 2019
739f77b
add deprecation TODO comments for unused color vars
shawnbot Oct 31, 2019
5cf3ba8
add deprecation TODO comments, reorganize misc variables, add !default
shawnbot Oct 31, 2019
8177332
enforce scss/dollar-variable-default specifically
shawnbot Oct 31, 2019
8b0f3ee
add !default in marketing/support/variables; plan removal of unused m…
shawnbot Oct 31, 2019
ce49044
move $display-values from utilities to support/variables/layout
shawnbot Oct 31, 2019
0d4fe91
move $edges from utilities to support/variables/layout
shawnbot Oct 31, 2019
d4f87e4
move stylelint-disable to devDeps
shawnbot Nov 1, 2019
46c60dc
use $text-black instead of $text-dark-gray
shawnbot Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 120 additions & 21 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
"test-migrate": "script/test-migrate"
},
"dependencies": {
"@primer/octicons": "^9.1.1"
"@primer/octicons": "^9.1.1",
"stylelint-disable": "^0.1.5"
},
"devDependencies": {
"@storybook/addon-viewport": "5.0.11",
Expand Down Expand Up @@ -73,7 +74,8 @@
"style-loader": "^0.18.2",
"styled-components": "4.1.2",
"stylelint": "^10.1.0",
"stylelint-config-primer": "^8.1.0",
"stylelint-config-primer": "^9.0.0",
"stylelint-only": "^1.0.1",
"table": "5.2.3",
"typographic-base": "^1.0.4",
"unified": "^7.1.0",
Expand Down
26 changes: 18 additions & 8 deletions src/alerts/flash.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
.flash {
position: relative;
padding: $spacer-3;
// stylelint-disable-next-line primer/colors
color: $blue-800;
// stylelint-disable-next-line primer/colors
background-color: $blue-100;
border: 1px solid $border-black-fade;
border-radius: 3px;
border: $border-width $border-style $border-black-fade;
border-radius: $border-radius;

p:last-child {
margin-bottom: 0;
Expand Down Expand Up @@ -40,6 +42,7 @@
// Action button
.flash-action {
float: right;
// stylelint-disable-next-line primer/spacing
margin-top: -3px;
margin-left: $spacer-4;
}
Expand All @@ -49,26 +52,31 @@
//

.flash-warn {
// stylelint-disable-next-line primer/colors
color: $yellow-900;
// stylelint-disable-next-line primer/colors
background-color: $yellow-100;
border-color: $black-fade-15;
border-color: $border-black-fade;
}

.flash-error {
// stylelint-disable-next-line primer/colors
color: $red-900;
background-color: $red-100;
border-color: $black-fade-15;
background-color: $bg-red-light;
border-color: $border-black-fade;
}

.flash-success {
// stylelint-disable-next-line primer/colors
color: $green-800;
background-color: $green-100;
border-color: $black-fade-15;
background-color: $bg-green-light;
border-color: $border-black-fade;
}

.flash-full {
// stylelint-disable-next-line primer/spacing
margin-top: -1px;
border-width: 1px 0;
border-width: $border-width 0;
border-radius: 0;
}

Expand All @@ -87,7 +95,9 @@
// FIXME deprecate this
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a good candidate for a [email protected] comment (see: #946).

.warning {
padding: $em-spacer-5;
// stylelint-disable-next-line primer/spacing
margin-bottom: 0.8em;
font-weight: $font-weight-bold;
// stylelint-disable-next-line primer/colors
background-color: $yellow-100;
}
2 changes: 2 additions & 0 deletions src/avatars/avatar-parent-child.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
right: -15%;
bottom: -9%;
background-color: $bg-white; // For transparent backgrounds
// stylelint-disable-next-line primer/borders
border-radius: 2px;
// stylelint-disable-next-line primer/box-shadow
box-shadow: -2px -2px 0 rgba($white, 0.8);
}
18 changes: 14 additions & 4 deletions src/avatars/avatar-stack.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@
width: 20px;
height: 20px;
box-sizing: content-box;
// stylelint-disable-next-line primer/spacing
margin-right: -11px;
background-color: $bg-white;
border-right: $border-width $border-style $white;
border-right: $border-width $border-style $border-white;
// stylelint-disable-next-line primer/borders
border-radius: 2px;
transition: margin 0.1s ease-in-out;

Expand All @@ -47,6 +49,7 @@

// stylelint-disable selector-max-type
img {
// stylelint-disable-next-line primer/borders
border-radius: 2px;
}
// stylelint-enable selector-max-type
Expand All @@ -60,6 +63,7 @@

&:hover {
.avatar {
// stylelint-disable-next-line primer/spacing
margin-right: 3px;
}

Expand All @@ -77,25 +81,28 @@
.avatar.avatar-more {
z-index: 1;
margin-right: 0;
background: $gray-100;
background: $bg-gray;

&::before,
&::after {
position: absolute;
display: block;
height: 20px;
content: "";
// stylelint-disable-next-line primer/borders
border-radius: 2px;
outline: $border-width $border-style $white;
}

&::before {
width: 17px;
// stylelint-disable-next-line primer/colors
background: $gray-200;
}

&::after {
width: 14px;
// stylelint-disable-next-line primer/colors
background: $gray-300;
}
}
Expand All @@ -109,11 +116,13 @@

&:hover .avatar {
margin-right: 0;
// stylelint-disable-next-line primer/spacing
margin-left: 3px;
}
}

.avatar.avatar-more {
// stylelint-disable-next-line primer/colors
background: $gray-300;

&::before {
Expand All @@ -122,14 +131,15 @@

&::after {
width: 2px;
background: $gray-100;
background: $bg-gray;
}
}

.avatar {
margin-right: 0;
// stylelint-disable-next-line primer/spacing
margin-left: -11px;
border-right: 0;
border-left: $border-width $border-style $white;
border-left: $border-width $border-style $border-white;
}
}
Loading