Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NavList component #427

Merged
merged 13 commits into from
May 24, 2022
Merged

Use NavList component #427

merged 13 commits into from
May 24, 2022

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented May 13, 2022

I replaced Doctocat's custom navigation components with the new NavList component.

Before

CleanShot 2022-05-20 at 12 59 40

After

CleanShot 2022-05-20 at 13 04 11


Breaking change

Items in nav.yml that contain children no longer render as links, meaning the url property will be ignored.

# nav.yml
– title: Components
- url: /components
  children:
   — title: Avatar
     url: /Avatar

Related https://github.com/github/primer/issues/395

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2022

🦋 Changeset detected

Latest commit: 3a9de25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/gatsby-theme-doctocat Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis temporarily deployed to github-pages May 13, 2022 19:30 Inactive
@colebemis colebemis temporarily deployed to github-pages May 19, 2022 23:31 Inactive
@colebemis colebemis temporarily deployed to github-pages May 20, 2022 20:00 Inactive
@colebemis colebemis temporarily deployed to github-pages May 20, 2022 20:09 Inactive
@colebemis colebemis marked this pull request as ready for review May 20, 2022 20:12
@colebemis colebemis temporarily deployed to github-pages May 20, 2022 20:15 Inactive
docs/package.json Outdated Show resolved Hide resolved
@colebemis
Copy link
Contributor Author

colebemis commented May 23, 2022

Tests are failing because JSDOM doesn't mock ResizeObserver.

@colebemis colebemis temporarily deployed to github-pages May 24, 2022 15:08 Inactive
@colebemis
Copy link
Contributor Author

@siddharthkp verbally approved this in a 1:1 ✅

@colebemis colebemis merged commit 5f4426c into main May 24, 2022
@colebemis colebemis deleted the navlist branch May 24, 2022 15:09
@primer-css primer-css mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant