Fix content blowout #739
Merged
Fix content blowout #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 19f85ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
In React Brand there are a few pages where the content on large screens is wider than other pages. At certain breakpoints it also overlaps the navigation. This is a quirk of a flex child not collapsing where its children have wider content than the flex calculation. The default min-width is auto, and since there are children with width: 100%, auto corresponds to max-content, which causes the blowout. To fix this we can set the min-width to 0, which will make the children respect the flex calculation. See https://css-tricks.com/flexbox-truncated-text/#aa-the-solution-is-min-width-0-on-the-flex-child
pouretrebelle
force-pushed
the
pouretrebelle/fix-blowout
branch
from
d5d0e66 to
352203a
Compare
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React Brand there are a couple of pages where the content on large screens is wider than other pages. At certain breakpoints it also overlaps the navigation:
This is a quirk of a flex child not collapsing where its children have wider content than the flex calculation. The default
min-widthisauto, and since there are children withwidth: 100%,autocorresponds tomax-content, which causes the blowout. To fix this we can set themin-widthto 0, which will make the children respect the flex calculation.See https://css-tricks.com/flexbox-truncated-text/#aa-the-solution-is-min-width-0-on-the-flex-child