Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to type: module #1058

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Move to type: module #1058

merged 2 commits into from
Sep 19, 2024

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Sep 17, 2024 •
edited
Loading

Summary

  • change to type: module in package.json
  • update tsconfig.json:
    • "module": "commonjs", → "module": "Node16",
    • "moduleResolution": "node", → "moduleResolution": "Node16",
  • add .js exntesions to all imports
  • add type assertion for import of json files
  • replace __dirname with es6 replacement in playwright.config.ts

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8274a6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Design Token Diff

No design tokens changed

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Sep 17, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 09:42 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 10:17 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 10:30 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 11:12 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 11:27 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 11:59 Inactive
@lukasoppermann lukasoppermann changed the title [Don't MERGE] testing Move to type module Sep 17, 2024
@lukasoppermann lukasoppermann changed the title Move to type module Move to type: module Sep 17, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 12:13 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 13:11 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 14:15 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 15:15 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 17, 2024 15:30 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 18, 2024 06:54 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 18, 2024 06:58 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 18, 2024 07:10 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 18, 2024 11:57 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 18, 2024 12:16 Inactive
@lukasoppermann lukasoppermann removed the skip changeset Apply to PRs that should not result in a version bump. label Sep 18, 2024
@lukasoppermann lukasoppermann marked this pull request as ready for review September 18, 2024 16:03
@lukasoppermann lukasoppermann requested review from a team as code owners September 18, 2024 16:03
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 18, 2024 16:08 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) September 18, 2024 16:10 Inactive
@lukasoppermann lukasoppermann merged commit 9c3b2c8 into main Sep 19, 2024
26 checks passed
@lukasoppermann lukasoppermann deleted the test-storybook branch September 19, 2024 06:20
@primer primer bot mentioned this pull request Sep 19, 2024
Merged
This was referenced Nov 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann