Deny tag argument for ActionList headings (#1871)

primer · Mar 8, 2023 · 6b1170a · 6b1170a
1 parent 0dbba6b
commit 6b1170a
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/.changeset/seven-tables-applaud.md b/.changeset/seven-tables-applaud.md
@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Deny tag argument for ActionList headings
diff --git a/app/components/primer/alpha/action_list/heading.rb b/app/components/primer/alpha/action_list/heading.rb
@@ -27,7 +27,7 @@ def initialize(list_id:, title:, heading_level: 3, scheme: DEFAULT_SCHEME, subti
 
           @heading_level = heading_level
           @tag = :"h#{heading_level}"
-          @system_arguments = system_arguments
+          @system_arguments = deny_tag_argument(**system_arguments)
           @list_id = list_id
           @title = title
           @subtitle = subtitle

diff --git a/test/components/alpha/action_list_test.rb b/test/components/alpha/action_list_test.rb
@@ -79,6 +79,16 @@ def test_renders_leading_visuals
 
         assert_selector(".ActionListItem-visual--leading", count: 2)
       end
+
+      def test_heading_denies_tag_argument
+        error = assert_raises ArgumentError do
+          render_inline(Primer::Alpha::ActionList.new(aria: { lable: "List" })) do |component|
+            component.with_heading(title: "Foo", tag: :foo)
+          end
+        end
+
+        assert_match(/This component has a fixed tag/, error.message)
+      end
     end
   end
 end