Remove trailing newlines from the output of LinkComponent (#1183)

* Remove trailing newlines from the output of LinkComponent

* Fix HTML escaping issue

.changeset/sour-berries-lick.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Remove trailing newlines from the output of LinkComponent

app/components/primer/link_component.rb

@@ -82,5 +82,11 @@ def initialize(href: nil, tag: DEFAULT_TAG, scheme: DEFAULT_SCHEME, muted: false
     def before_render
       raise ArgumentError, "href is required when using <a> tag" if @system_arguments[:tag] == :a && @system_arguments[:href].nil? && !Rails.env.production?
     end
+
+    def call
+      render(Primer::BaseComponent.new(**@system_arguments)) do
+        content.to_s + tooltip.to_s
+      end
+    end
   end
 end

test/components/link_component_test.rb

@@ -18,6 +18,12 @@ def test_renders_no_additional_whitespace
     assert_text(/^content$/)
   end
 
+  def test_renders_without_trailing_newline
+    render_inline(Primer::LinkComponent.new(href: "http://joe-jonas-shirtless.com")) { "content" }
+
+    refute @rendered_content.end_with?("\n")
+  end
+
   def test_renders_as_a_link
     render_inline(Primer::LinkComponent.new(href: "http://google.com")) { "content" }