Prevent rounded corners in the middle of a BorderBox

primer · Mar 12, 2024 · c3c60f0 · c3c60f0
1 parent 53a3390
commit c3c60f0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.changeset/proud-pens-dress.md b/.changeset/proud-pens-dress.md
@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Prevent rounded corners in the middle of a Primer::Beta::BorderBox
diff --git a/app/components/primer/beta/border_box.pcss b/app/components/primer/beta/border_box.pcss
@@ -89,7 +89,7 @@
   border-bottom: var(--borderWidth-thin) solid var(--borderColor-default);
 
   /* Ensures bottom-border doesn't poke out when .Box-body used without box-footer */
-  &:last-of-type {
+  &:last-child {
     margin-bottom: calc(var(--borderWidth-thin) * -1);
     border-bottom-right-radius: var(--borderRadius-medium);
     border-bottom-left-radius: var(--borderRadius-medium);
@@ -106,8 +106,7 @@
   border-top-width: var(--borderWidth-thin);
 
   &:first-of-type {
-    border-top-left-radius: var(--borderRadius-medium);
-    border-top-right-radius: var(--borderRadius-medium);
+    border-top-width: 0;
   }
 
   &:last-of-type {