Set aria-hidden="true" when type is label (#1247)

* add aria-hidden when type is label * Create eighty-hounds-cheer.md
primer · Jul 30, 2022 · dbe606b · dbe606b
1 parent 3facfce
commit dbe606b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/eighty-hounds-cheer.md b/.changeset/eighty-hounds-cheer.md
@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Set `aria-hidden="true"` when type is label
diff --git a/app/assets/javascripts/primer_view_components.js b/app/assets/javascripts/primer_view_components.js
diff --git a/app/assets/javascripts/primer_view_components.js.map b/app/assets/javascripts/primer_view_components.js.map
diff --git a/app/components/primer/alpha/tool-tip-element.ts b/app/components/primer/alpha/tool-tip-element.ts
@@ -254,6 +254,7 @@ class ToolTipElement extends HTMLElement {
       if (!this.id || !this.control) return
       if (this.type === 'label') {
         this.control.setAttribute('aria-labelledby', this.id)
+        this.setAttribute('aria-hidden', 'true')
       } else {
         let describedBy = this.control.getAttribute('aria-describedby')
         describedBy ? (describedBy = `${describedBy} ${this.id}`) : (describedBy = this.id)