Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use rubocop for erb #1211

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Dont use rubocop for erb #1211

merged 2 commits into from
Jul 21, 2022

Conversation

camertron
Copy link
Contributor

Reverts #1200

Unfortunately this caused ~25k new violations to be reported in dotcom 😳 which I don't have the bandwidth to fix.

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2022

🦋 Changeset detected

Latest commit: ae4eb30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron temporarily deployed to github-pages July 20, 2022 20:06 Inactive
@camertron camertron marked this pull request as ready for review July 21, 2022 04:30
@camertron camertron requested review from a team and hectahertz July 21, 2022 04:30
@camertron camertron merged commit 047c6be into main Jul 21, 2022
@camertron camertron deleted the dont_use_rubocop_for_erb branch July 21, 2022 17:47
@primer-css primer-css mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants