Move tooltip to be sibling of link #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8c97e09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
khiga8
commented
Aug 1, 2022
| @@ -43,9 +45,6 @@ class LinkComponent < Primer::Component | |||
| # @example Without underline | |||
| # <%= render(Primer::LinkComponent.new(href: "#", underline: false)) { "Link" } %> | |||
| # | |||
| # @example Span as link | |||
There was a problem hiding this comment.
I don't think this is a good usecase so we should remove this example.
Merged
This was referenced Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Linkcomponent now supports rendering of tooltip through its API.Currently the tooltip element is nested within the anchor element. However this will result in the tooltip element becoming a touch area for the link which is unexpected behavior.
Instead the tooltip element should be rendered adjacent to the anchor.
Additionally, to ensure the tooltip (which uses absolute positioning) is positioned correctly, this PR adds a
position: 'relativecontainer that wraps the tooltip and the anchor element. I made this aspanto mimicinlinepositioning of link.