Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint custom-element rules so web components can match ruby component names #1352

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 7, 2022

In this PR I wanted to update the .eslintrc.json rule so that we can keep matching naming in our component asset files.

"custom-elements/file-name-matches-element": [
    "error", {"suffix": "Element", "transform": "snake"}
],

This allows us to keep all corresponding files for a component the same name.

Before After
image image

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022

🦋 Changeset detected

Latest commit: 4043d57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan marked this pull request as ready for review September 7, 2022 16:45
@jonrohan jonrohan requested review from a team and keithamus September 7, 2022 16:45
@jonrohan jonrohan enabled auto-merge (squash) September 7, 2022 16:45
@jonrohan jonrohan temporarily deployed to github-pages September 7, 2022 16:49 Inactive
@jonrohan jonrohan temporarily deployed to github-pages September 7, 2022 16:55 Inactive
@jonrohan jonrohan disabled auto-merge September 7, 2022 18:01
@jonrohan jonrohan merged commit a02944b into main Sep 7, 2022
@jonrohan jonrohan deleted the eslint_config_update branch September 7, 2022 18:01
@primer-css primer-css mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant