Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying an unchecked value for check box inputs #1424

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Allow specifying an unchecked value for check box inputs #1424

merged 3 commits into from
Sep 30, 2022

Conversation

camertron
Copy link
Contributor

Right now, the check box input doesn't allow specifying an unchecked value. This PR adds that option.

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: c481da1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron requested a review from neall September 29, 2022 20:38
@camertron camertron temporarily deployed to review-pr-1424 September 29, 2022 20:38 Inactive
@camertron camertron temporarily deployed to github-pages September 29, 2022 20:41 Inactive
@camertron camertron marked this pull request as ready for review September 29, 2022 21:01
@camertron camertron requested review from a team and keithamus September 29, 2022 21:01
@jonrohan jonrohan temporarily deployed to review-pr-1424 September 30, 2022 16:20 Inactive
@jonrohan jonrohan temporarily deployed to github-pages September 30, 2022 16:26 Inactive
@jonrohan jonrohan temporarily deployed to github-pages September 30, 2022 17:40 Inactive
jonrohan
jonrohan approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok to me, not sure if you also want @neall to weigh in

@camertron
Copy link
Contributor Author

camertron commented Sep 30, 2022 •
edited
Loading

@jonrohan as a matter of fact @neall and I paired on this, so that's tacit approval I'd say.

@camertron camertron merged commit d7b277e into main Sep 30, 2022
@camertron camertron deleted the unchecked_value_for_check_box branch September 30, 2022 17:53
@primer-css primer-css mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@neall neall Awaiting requested review from neall

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camertron @jonrohan