Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested forms for check boxes #1498

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Add nested forms for check boxes #1498

merged 1 commit into from
Oct 17, 2022

Conversation

neall
Copy link
Contributor

@neall neall commented Oct 14, 2022

Description

This follows the same pattern as nested forms for radio buttons.

Integration

Nothing in production uses this yet.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022

🦋 Changeset detected

Latest commit: bffc1c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neall neall temporarily deployed to review-pr-1498 October 14, 2022 20:06 Inactive
@neall neall temporarily deployed to github-pages October 14, 2022 20:11 Inactive
@neall neall force-pushed the neall/checkbox-nested-form branch from 9dff037 to 4baceb3 Compare October 17, 2022 19:13
This is similar to nested forms for radio buttons.
@neall neall force-pushed the neall/checkbox-nested-form branch from 4baceb3 to bffc1c8 Compare October 17, 2022 19:13
@neall neall temporarily deployed to github-pages October 17, 2022 19:18 Inactive
@neall neall marked this pull request as ready for review October 17, 2022 20:44
@neall neall requested review from a team and jonrohan October 17, 2022 20:44
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@jonrohan jonrohan merged commit b3668d3 into main Oct 17, 2022
@jonrohan jonrohan deleted the neall/checkbox-nested-form branch October 17, 2022 22:53
@primer-css primer-css mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants