Banner component #1533
Merged
Banner component #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to flash_redesign
Co-authored-by: Jon Rohan <[email protected]>
…s based on scheme
…to flash_redesign
… since that will always be the dismiss button
…to flash_redesign
🦋 Changeset detectedLatest commit: e07c525 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
css
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
Bannercomponent, which will eventually form the basis for an improvedFlashcomponent. I'd like to ship this before shipping theFlashcomponent upgrade. The idea here is thatFlashis aBannerwith some extra javascript for announcing the message to screen readers.Integration
No, prod uses the
Flashcomponent to display banners.Flashshould only be used to display announced alert and status messages, so my plan is to replace all usages ofFlashwithBannerin dotcom, then land theFlashupgrade and start using it for flash-specific purposes in dotcom.Merge checklist