Allow form field names to end in "?" #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ba3f20d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rails will allow input names that end in a question mark and call the appropriate method on the model to (for example) decide if a checkbox should start off as "checked". This change ensures we can still find a caption template associated with a field named with a question mark, but not have to embed a question mark in the template file name. Co-Authored-By: Cameron Dutro <[email protected]>
neall
force-pushed
the
neall/allow-question-marks-in-form-field-names
branch
from
14d1352 to
ba3f20d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rails will allow input names that end in a question mark and call the appropriate method on the model to (for example) decide if a checkbox should start off as "checked". This change ensures we can still find a caption template associated with a field named with a question mark, but not have to embed a question mark in the template file name.
Integration
No changes in production. (Prod doesn't use this feature yet.)
Merge checklist
Added/updated documentation