-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lazy loader to action_controller_base #1595
Conversation
🦋 Changeset detectedLatest commit: d94c517 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey @soberstadt, can you provide a bit more info around why this change is necessary? Things seem to be working for us as-is. |
Do you have an controllers that directly extend |
Demo app: https://github.com/soberstadt/view_components1595 |
To further clarify, this issue was found while using Doorkeeper's token info api (which by default inherits from |
Hey @soberstadt, apologies for the delay here. I'm still not sure I understand the change, but if it works for you and doesn't adversely affect github.com, I'm ok merging it. Could you add a changeset when you get a chance? Run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Instances of
ActionController::API
subclasses are currently incompatible with the primer engine.Integration
No breaking changes.
Merge checklist