Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CounterComponet for Counter #1605

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

jonrohan
Copy link
Member

Description

With https://github.com/github/github/pull/246687 merging, there will be no more uses of the deprecated Primer::CounterComponent namespace. This PR removes it from the codebase.

Integration

Does this change require any updates to code in production?

Yes https://github.com/github/github/pull/246687 should be merged first

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@jonrohan jonrohan requested review from a team and keithamus November 14, 2022 22:29
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2022

🦋 Changeset detected

Latest commit: 4ae8ab5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Nov 14, 2022
@jonrohan jonrohan merged commit 63b40c1 into main Nov 15, 2022
@jonrohan jonrohan deleted the delete_primer_counter_component branch November 15, 2022 00:56
@primer-css primer-css mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants