Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting deprecated Primer::Image component #1624

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Deleting deprecated Primer::Image component #1624

merged 3 commits into from
Nov 22, 2022

Conversation

jonrohan
Copy link
Member

Description

The previously deprecated Image has been completely migrated to Primer::Alpha::Image in production. This removes the old class.

Integration

Does this change require any updates to code in production?

Double check no Primer::Image calls were added.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@jonrohan jonrohan requested review from a team and keithamus November 19, 2022 01:54
@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 3656776

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Nov 19, 2022
@jonrohan jonrohan temporarily deployed to github-pages November 19, 2022 01:59 Inactive
@jonrohan jonrohan requested a review from simurai November 21, 2022 23:51
@simurai simurai enabled auto-merge (squash) November 22, 2022 10:53
@simurai simurai merged commit 61c8a7d into main Nov 22, 2022
@simurai simurai deleted the deprecated_components/delete_image branch November 22, 2022 10:57
@primer-css primer-css mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @simurai