Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Primer::Dropdown moving to Primer::Alpha::Dropdown #1625

Merged
merged 12 commits into from
Nov 22, 2022
Merged

Deprecate Primer::Dropdown moving to Primer::Alpha::Dropdown #1625

merged 12 commits into from
Nov 22, 2022

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Nov 19, 2022 •
edited
Loading

Description

Part of #676

This renames the Primer::Dropdown component to the module Primer::Alpha::Dropdown as well as the subclasses.

      "Primer::Dropdown" => "Primer::Alpha::Dropdown",
      "Primer::Dropdown::Menu" => "Primer::Alpha::Dropdown::Menu",
      "Primer::Dropdown::Menu::Item" => "Primer::Alpha::Dropdown::Menu::Item"

Integration

Does this change require any updates to code in production?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@jonrohan jonrohan requested a review from a team as a code owner November 19, 2022 02:15
@jonrohan jonrohan requested review from a team, simurai and keithamus November 19, 2022 02:15
@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: d643de7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added css Pull requests that update CSS code javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code labels Nov 19, 2022
@jonrohan jonrohan temporarily deployed to review-pr-1625 November 19, 2022 02:20 Inactive
@jonrohan jonrohan temporarily deployed to github-pages November 19, 2022 02:25 Inactive
@github-actions
Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@jonrohan jonrohan temporarily deployed to review-pr-1625 November 21, 2022 16:29 Inactive
@jonrohan jonrohan temporarily deployed to github-pages November 21, 2022 16:33 Inactive
@jonrohan jonrohan temporarily deployed to review-pr-1625 November 21, 2022 18:55 Inactive
@jonrohan jonrohan temporarily deployed to github-pages November 21, 2022 18:59 Inactive
@jonrohan jonrohan temporarily deployed to review-pr-1625 November 21, 2022 23:27 Inactive
@jonrohan jonrohan temporarily deployed to github-pages November 21, 2022 23:32 Inactive
@jonrohan jonrohan temporarily deployed to review-pr-1625 November 21, 2022 23:48 Inactive
@jonrohan jonrohan temporarily deployed to github-pages November 21, 2022 23:54 Inactive
@jonrohan jonrohan temporarily deployed to github-pages November 22, 2022 00:07 Inactive
@jonrohan jonrohan merged commit 3af9bf5 into main Nov 22, 2022
@jonrohan jonrohan deleted the deprecate_dropdown branch November 22, 2022 17:27
@primer-css primer-css mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
css Pull requests that update CSS code javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @simurai