Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Overlay styles to PVC #1648

Closed
wants to merge 4 commits into from

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Nov 29, 2022

Description

This is part of #1342 and on top of #1401. It adds the Overlay styles from PCSS. There should be no visual changes.

Integration

Does this change require any updates to code in production?

Yes, the following lines can be removed on dotcom:

- @import '@primer/css/overlay/overlay.scss';

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2022

⚠️ No Changeset found

Latest commit: b14e23f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the css Pull requests that update CSS code label Nov 29, 2022
primer-overlay[popover='auto' i].\:open,
primer-overlay[popover='manual' i].\:open {
display: block;
position: fixed;
z-index: 2147483647;
}
} */

/* stylelint-enable selector-class-pattern */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only commented out these primer-overlay styles. It seems to be "test styles", but I assume they can be removed again at some point?

Before After
Screen Shot 2022-11-29 at 17 56 52 Screen Shot 2022-11-29 at 17 57 32

@simurai simurai temporarily deployed to github-pages November 29, 2022 10:59 Inactive
@simurai
Copy link
Contributor Author

simurai commented Nov 30, 2022

@keithamus Not sure what the status of #1648 is, but feel free to merge in these styles if you like. Or you can also leave them as a separate PR and we can merge them later.

@simurai simurai marked this pull request as ready for review November 30, 2022 05:01
@simurai simurai requested a review from a team as a code owner November 30, 2022 05:01
@simurai simurai requested review from a team, tobiasahlin, camertron and keithamus November 30, 2022 05:01
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get these into main and forgo merging into #1401 for now. I'll rebase #1401 after the fact, as Dialog also uses these styles.

@simurai simurai mentioned this pull request Dec 1, 2022
4 tasks
@simurai
Copy link
Contributor Author

simurai commented Dec 1, 2022

Superseded by #1651 that is intended to be merged into main.

@simurai simurai closed this Dec 1, 2022
@simurai simurai deleted the overlay-pcss branch December 1, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants