-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Overlay
styles to PVC
#1648
Conversation
|
primer-overlay[popover='auto' i].\:open, | ||
primer-overlay[popover='manual' i].\:open { | ||
display: block; | ||
position: fixed; | ||
z-index: 2147483647; | ||
} | ||
} */ | ||
|
||
/* stylelint-enable selector-class-pattern */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keithamus Not sure what the status of #1648 is, but feel free to merge in these styles if you like. Or you can also leave them as a separate PR and we can merge them later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superseded by #1651 that is intended to be merged into |
Description
This is part of #1342 and on top of #1401. It adds the
Overlay
styles from PCSS. There should be no visual changes.Integration
Yes, the following lines can be removed on dotcom:
- @import '@primer/css/overlay/overlay.scss';
Merge checklist
Added/updated documentation