Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating ComponentNameMigration and Rubocop / ERBLint CI steps #1699

Merged
merged 17 commits into from
Dec 19, 2022
Merged

Updating ComponentNameMigration and Rubocop / ERBLint CI steps #1699

merged 17 commits into from
Dec 19, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Dec 9, 2022 •
edited
Loading

Description

This PR adjusts the rubocop ComponentNameMigration rule with a few key changes:

  • using the new message formatter to provide a comprehensive deprecation message
  • allow reporting at different severity levels for erblint and rubocop, in PVC
  • adjust the severity for PVC's CI to report linter offenses as info instead of failures (preventing CI failure while still showing the offense)

the deprecation messages have also been updated to always include the replacement component when there is one, making it easier for a developer to know which component to use.

Integration

Does this change require any updates to code in production?

no

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: b9d7861

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxriverlynn mxriverlynn temporarily deployed to review-pr-1699 December 9, 2022 16:41 — with GitHub Actions Inactive
@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Dec 9, 2022
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 9, 2022 16:45 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 9, 2022 19:18 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 9, 2022 19:33 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 9, 2022 19:44 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1699 December 9, 2022 19:44 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 9, 2022 19:48 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1699 December 9, 2022 20:09 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 9, 2022 20:12 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 9, 2022 20:27 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn force-pushed the mxriverlynn/rubocop-ci-deprecations branch from fa6b4d4 to 2041683 Compare December 9, 2022 20:34
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 9, 2022 20:49 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1699 December 9, 2022 20:52 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 9, 2022 20:57 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 19, 2022 14:50 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn marked this pull request as ready for review December 19, 2022 15:05
@mxriverlynn mxriverlynn requested review from a team and keithamus December 19, 2022 15:05
@mxriverlynn mxriverlynn changed the title [WIP] updating rubocop ci for pvc Updating Rubocop and ERBLint CI steps Dec 19, 2022
@mxriverlynn mxriverlynn changed the title Updating Rubocop and ERBLint CI steps Updating ComponentNameMigration and Rubocop / ERBLint CI steps Dec 19, 2022
@mxriverlynn mxriverlynn merged commit 1449823 into main Dec 19, 2022
@mxriverlynn mxriverlynn deleted the mxriverlynn/rubocop-ci-deprecations branch December 19, 2022 18:46
@primer-css primer-css mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@keithamus keithamus Awaiting requested review from keithamus

@joelhawksley joelhawksley Awaiting requested review from joelhawksley

@camertron camertron Awaiting requested review from camertron

Assignees
No one assigned
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxriverlynn @jonrohan