Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly deprecate Primer::TimelineItemComponent::BadgeComponent in favor of Primer::Beta::TimelineItem::Badge #1729

Merged
merged 5 commits into from
Dec 29, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Dec 22, 2022

Description

Correctly deprecate Primer::TimelineItemComponent::BadgeComponent in favor of Primer::Beta::TimelineItem::Badge

Integration

Does this change require any updates to code in production?

No immediate changes, though deprecated components need to be cleaned up

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2022

🦋 Changeset detected

Latest commit: 99a6bf8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Dec 22, 2022
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 22, 2022 15:33 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn marked this pull request as ready for review December 22, 2022 15:39
@mxriverlynn mxriverlynn requested review from a team, camertron and jonrohan December 22, 2022 15:39
@mxriverlynn mxriverlynn mentioned this pull request Dec 22, 2022
54 tasks
@jonrohan jonrohan merged commit 897b352 into main Dec 29, 2022
@jonrohan jonrohan deleted the mxriverlynn/move-timeline-badge-component branch December 29, 2022 17:10
@primer-css primer-css mentioned this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants