Remove duplicate aria-label in CloseButton
#1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0e801c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paulcsmith
commented
Feb 2, 2023
| @@ -28,7 +28,7 @@ def initialize(type: DEFAULT_TYPE, **system_arguments) | |||
| "close-button", | |||
| system_arguments[:classes] | |||
| ) | |||
| @system_arguments[:"aria-label"] ||= "Close" | |||
| @system_arguments[:"aria-label"] = aria("label", system_arguments) || "Close" | |||
There was a problem hiding this comment.
The aria method gets the attribute from either a String or a nested hash:
view_components/app/components/primer/component.rb
Lines 49 to 51 in 79d2b02
paulcsmith
changed the title
aria-label in CloseButton
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
CloseButtonhad an issue where usingaria: { label: "foo" }would result in multiplearia-labelattributes in the generated HTML.This fixes the issue by using the
ariahelper method that will check for nested hash keys or a String aria-labelIntegration
No. This should work as-is
Merge checklist