Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleSwitch and SegmentedControl visual updates + Primitives (PCSS) version bump #1824

Merged
merged 8 commits into from
Feb 17, 2023
Merged

ToggleSwitch and SegmentedControl visual updates + Primitives (PCSS) version bump #1824

merged 8 commits into from
Feb 17, 2023

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Feb 10, 2023 •
edited
Loading

Co-authored-by: Mike Perrotti [email protected]

Description

Visual design updates to ToggleSwitch and SegmentedControl (required a change from Primitives, which required a bump in PCSS)

Integration

Does this change require any updates to code in production?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@langermank @mperrotti
test primitives release
26b21c7 
Co-authored-by: Mike Perrotti <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 458df34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the css Pull requests that update CSS code label Feb 10, 2023
@langermank langermank temporarily deployed to github-pages February 10, 2023 19:32 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2023 •
edited
Loading

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@langermank langermank changed the title test primitives release ToggleSwitch and SegmentedControl visual updates + Primitives (PCSS) version bump Feb 10, 2023
@mperrotti mperrotti mentioned this pull request Feb 10, 2023
Merged
5 tasks
@mperrotti mperrotti temporarily deployed to github-pages February 10, 2023 20:19 — with GitHub Actions Inactive
@langermank langermank marked this pull request as ready for review February 10, 2023 20:42
@langermank langermank requested a review from a team as a code owner February 10, 2023 20:42
@langermank langermank requested review from a team, simurai and camertron February 10, 2023 20:42
@langermank langermank temporarily deployed to github-pages February 10, 2023 20:45 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to review-pr-1824 February 13, 2023 07:04 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to github-pages February 13, 2023 07:05 — with GitHub Actions Inactive
simurai
simurai approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual design updates

I assume accessibility related? Making the ToggleSwitch-knob have more contrast?

Lookbook looks good.

But not sure about the docs, renders like:

Default Disabled
Screen Shot 2023-02-13 at 16 00 21 Screen Shot 2023-02-13 at 16 00 53

Maybe some sort of dependency glitch? 🤷

@jonrohan
Copy link
Member

But not sure about the docs, renders like:

Hmm, the docs dependency might need a bump too

@mperrotti mperrotti temporarily deployed to review-pr-1824 February 16, 2023 21:05 — with GitHub Actions Inactive
@mperrotti
Copy link
Contributor

Thanks @simurai and @jonrohan. I bumped the dependency in docs/ as well. Should be good-to-go now 👍

@simurai
Copy link
Contributor

simurai commented Feb 17, 2023 •
edited
Loading

I bumped the dependency in docs/ as well. Should be good-to-go now 👍

Great. 🎉 For some reason when the github-actions[bot] creates a new snapshot, like e4e12eb, CI is not triggered:

Screen Shot 2023-02-17 at 10 42 25

It will probably work by just making another "empty" commit, but would be nice to somehow fix it. /cc @jonrohan ?

@langermank langermank merged commit 2a23453 into main Feb 17, 2023
@langermank langermank deleted the bump-primitives branch February 17, 2023 18:45
@primer-css primer-css mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

@jonrohan jonrohan jonrohan approved these changes

@camertron camertron Awaiting requested review from camertron

Assignees
No one assigned
Labels
css Pull requests that update CSS code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@langermank @jonrohan @mperrotti @simurai