Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump octicons to v18 #1876

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Bump octicons to v18 #1876

merged 4 commits into from
Mar 10, 2023

Conversation

antn
Copy link
Contributor

@antn antn commented Mar 10, 2023

Description

This updates octicons to use v18+, so we can use the icons added in primer/octicons#928. This is part of https://github.com/github/discussions/issues/3079.

Integration

Does this change require any updates to code in production?

The only breaking change in v18 is changing the following icon names:

  • issue-tracked-byissue-tracks
  • issue-tracked-inissue-tracked-by

I don't see those being used anywhere in Dotcom.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@antn antn requested review from a team and keithamus March 10, 2023 03:16
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

🦋 Changeset detected

Latest commit: c4a22fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@antn
Copy link
Contributor Author

antn commented Mar 10, 2023

Not sure how we handle bumping versions of dependencies with breaking changes for this project, since there isn't a 1.0 yet. Should this just be 0.2.0?

@camertron
Copy link
Contributor

camertron commented Mar 10, 2023

Hey @antn, we've been bumping the patch version only for this project, regardless of breaking changes. Unfortunately I let a minor version bump through by accident which is how we ended up on v0.1.x 🤦 Let's keep bumping the minor version.

Oh, and could you please add a changeset? npx changeset.

@antn
Copy link
Contributor Author

antn commented Mar 10, 2023

@camertron yeah, I went to make a changeset but I wasn't sure how we wanted to handle the versioning. Thanks for clarifying! Added in ec4f99c.

@keithamus
Copy link
Member

the minor version

Minor or Patch, just to be sure @camertron?

@jonrohan jonrohan merged commit b3b94e9 into primer:main Mar 10, 2023
@primer-css primer-css mentioned this pull request Mar 10, 2023
@camertron
Copy link
Contributor

Woops sorry @keithamus and @antn, I meant to say let's bump the patch version 🤦

No problem, I can adjust the changeset in master.

@camertron
Copy link
Contributor

Ah never mind, looks like @jonrohan took care of it before merge 🚀

@antn antn deleted the octicons-v18 branch March 10, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants