-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump octicons
to v18
#1876
Bump octicons
to v18
#1876
Conversation
🦋 Changeset detectedLatest commit: c4a22fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Not sure how we handle bumping versions of dependencies with breaking changes for this project, since there isn't a 1.0 yet. Should this just be |
Hey @antn, we've been bumping the patch version only for this project, regardless of breaking changes. Unfortunately I let a minor version bump through by accident which is how we ended up on v0.1.x 🤦 Let's keep bumping the minor version. Oh, and could you please add a changeset? |
@camertron yeah, I went to make a changeset but I wasn't sure how we wanted to handle the versioning. Thanks for clarifying! Added in ec4f99c. |
Minor or Patch, just to be sure @camertron? |
Woops sorry @keithamus and @antn, I meant to say let's bump the patch version 🤦 No problem, I can adjust the changeset in master. |
Ah never mind, looks like @jonrohan took care of it before merge 🚀 |
Description
This updates
octicons
to use v18+, so we can use the icons added in primer/octicons#928. This is part of https://github.com/github/discussions/issues/3079.Integration
The only breaking change in v18 is changing the following icon names:
issue-tracked-by
→issue-tracks
issue-tracked-in
→issue-tracked-by
I don't see those being used anywhere in Dotcom.
Merge checklist