Fix keyboard functionality with deferred loading in ActionMenu #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1658de2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
requested review from
a team,
jonrohan,
langermank and
keithamus
and removed request for
jonrohan
keithamus
reviewed
Jun 6, 2023
keithamus
approved these changes
Jun 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR addresses the keyboard accessibility issues described in https://github.com/github/primer/issues/2245.
Screenshots
See the issue linked above for a "before" video.
After:
action_menu_keyboard_deferred_loading.mov
Integration
This change does not require any changes to production.
List the issues that this change affects.
Fixes: https://github.com/github/primer/issues/2245
Risk Assessment
What approach did you choose and why?
I removed our handling of the
focusoutevent and replaced it with code that handles events from the<include-fragment-element>to focus the first element after deferred content has loaded.Anything you want to highlight for special attention from reviewers?
I discovered the issue was that we were improperly handling the
focusoutevent by using it to close the popover. This code was part of the original component built by the a11y team, so I fear I may have removed important functionality. Removing it however does not cause any tests to fail, so I assume we're good, but I need someone familiar with that old code to examine this PR carefully.Accessibility
Merge checklist
- [ ] Added/updated documentationTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.