Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'skip changelog' label to 'skip changeset' #2089

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

We'd like to change the skip changelog label to skip changeset to better reflect how we work and for consistency with primer/react. Several of our workflows are expecting the old skip changelog label. This PR corrects them.

Integration

No code changes required in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@camertron camertron added the skip changeset Pull requests that don't change the library output label Jun 22, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

🦋 Changeset detected

Latest commit: 1e34397

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron temporarily deployed to preview June 22, 2023 22:28 — with GitHub Actions Inactive
@camertron
Copy link
Contributor Author

camertron commented Jun 22, 2023

Note that the "Check for changeset" check is going to fail until we update the label... which we shouldn't do until this PR is merged.

@camertron camertron temporarily deployed to github-pages June 22, 2023 22:32 — with GitHub Actions Inactive
@camertron camertron marked this pull request as ready for review June 22, 2023 22:36
@camertron camertron requested review from a team and keithamus June 22, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants