allow dialogs within deferred menus

[keithamus]

What are you trying to accomplish?

There are instances when one wants to render dialog contents deferred through the ActionMenu. Currently this doesn't work; it's buggy. The current behaviour is that the dialog flashes open, then hides because the ActionMenu itself closes. Re-opening the menu causes the Dialog to appear.

This is of course not ideal. We should enable this pattern to be expressed bug free.

/cc @jdennes

Screenshots

Here's the broken behaviour:

screen-recorder-thu-aug-17-2023-13-37-30.webm

Here it is fixed:

screen-recorder-thu-aug-17-2023-13-36-05.webm

Integration

No

List the issues that this change affects.

An issue hasn't been filed. This was from Slack.

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

• No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 5038511

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[camertron]

Wow what an interesting use-case! The code looks good, but I'd love to see some system tests for this 👍

[keithamus]

@camertron added a system test!