-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow several font sizes for Subhead headings #2330
Conversation
🦋 Changeset detectedLatest commit: 3888ac4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for working on this, @camertron! Let's make sure to get an approval from someone on Primer Design on this PR before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting primitives, but not blocking
Co-authored-by: Katie Langerman <[email protected]>
Co-authored-by: Katie Langerman <[email protected]>
What are you trying to accomplish?
This PR allows adjusting the (font) size of headings in the
Subhead
component. A Hubber asked in Slack whySubhead
headings in PVC have a font size of 24px, but a font size of 20px in PRC and in Figma. Rather than change the font size and potentially mess with a bunch of existing usages in dotcom, I have chosen to introduce two heading sizes, large (the default), and medium.Screenshots
Integration
No changes necessary in production.
Risk Assessment
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.