-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapts Blankslate to render proportionally in narrow areas #2337
Conversation
🦋 Changeset detectedLatest commit: 11e4e20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Uh oh! @mperrotti, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just needs a changeset and should be good to merge
…view_components into mp/responsive-blankslate
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Use container queries to adjust the spacing and sizing of the Blankslate component to work well in small areas.
Screenshots
Before:
After:
Integration
No production updates required
List the issues that this change affects.
Relates to https://github.com/github/primer/issues/2678
Risk Assessment
What approach did you choose and why?
I chose container queries over a new "small" variant because it's very unlikely we'd want large text and a lot of spacing in a Blankslate that's used in a small area.
Anything you want to highlight for special attention from reviewers?
No
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.