Fix: Primer::Beta::RelativeTime does not correctly accept "month" attribute #2408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The component
Primer::Beta::RelativeTime
accepts asystem_argument[:month]
. This was set viafetch_or_fallback
method. However, there was the wrong variable used for the first parameter (the allowed values).Integration
List the issues that this change affects.
Closes #2407
Risk Assessment
What approach did you choose and why?
nil
, it shouldn't make any difference in the result.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.