Make dismiss action on Banner changeable #2455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
Alpha::Banner
component has the option to dismiss the banner via a button showing an "x". This button has anaria-label
attribute with the hard coded text "Dismiss". This text is not changable. This PR aims to make the dismiss action customizable, e.g to open it for translations or different texts if the context requires it.List the issues that this change affects.
Closes #2453
Risk Assessment
Merge checklist