Prevent an empty list of custom regexes in the DetailsMenuMigration linter from reporting false positives

[camertron]

What are you trying to accomplish?

A recent PR introduced the ability to add custom regexes to the DetailsMenuMigration linter to provide 3rd-party code a way to customize how the linter identifies violations. Unfortunately if the list of custom regexes is empty, the linter checks all code against an empty regex (eg. //i), which matches every string and therefore always returns true. This results in false-positives for every line of code in the file.

Integration

No changes necessary in production.

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I modified the linter to skip matching with the custom regexes if the list of custom regexes is empty.

Accessibility

• No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

• Added/updated tests
  - [ ] Added/updated documentation
  - [ ] Added/updated previews (Lookbook)
  - [ ] Tested in Chrome
  - [ ] Tested in Firefox
  - [ ] Tested in Safari
  - [ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: c5160ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[jamieshark]

thanks for this fix!