Hide "loading" screen reader-only text after visual spinner leaves #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't be discoverable after the content has loaded. This issue was discovered when testing the alpha version of the `SelectPanel`, so it also fixes an `eventually_local` `SelectPanel` not having a `src` attribute as described in documentation.
🦋 Changeset detectedLatest commit: ab4b5dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
requested changes
Aug 16, 2024
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes 2 bugs which are related, in closing the issue referenced below:
eventually_localSelectPanels don't have asrcattribute, which they should according to theSelectPaneldocumentation.loadingscreen reader text for spinners should be removed after the content has loaded/the visual spinner has been hidden so users don't discover it and get confused exploring post-load.List the issues that this change affects.
Closes https://github.com/github/primer/issues/3690
Risk Assessment
Anything you want to highlight for special attention from reviewers?
I manually tested this against the Lookbook examples for different
fetch_strategiesto ensure there aren't surprise visual regressions.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.