remove redundant code from action-bar-element #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
This comment was marked as resolved.
This comment was marked as resolved.
keithamus
force-pushed
the
remove-redundant-code-from-action-bar-element
branch
from
7043c09 to
8c79807
Compare
Co-authored-by: AdamShwert <[email protected]> Co-authored-by: Alon Dahari <[email protected]> Co-authored-by: Arelia Jones <[email protected]> Co-authored-by: Cam McHenry <[email protected]> Co-authored-by: Chris Maynard <[email protected]> Co-authored-by: Cody Bodfield <[email protected]> Co-authored-by: Dusty Greif <[email protected]> Co-authored-by: Jibran Garcia <[email protected]> Co-authored-by: Marie Lucca <[email protected]>
keithamus
force-pushed
the
remove-redundant-code-from-action-bar-element
branch
from
9451345 to
04f653b
Compare
jonrohan
approved these changes
Dec 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
In our fortnightly performance mob-pairing session we noticed that there's a large Recalculate Style going on because
action-bar-elementloops through all the items to calculate the width to supply to thedata-offset-widthattribute. It turns out though, that this attribute isn't actually used any more, so this code is entirely redundant.In #2425 the action bar code was refactored and the places that used
data-offset-widthwere removed, however this loop remained.By simply deleting this code we can eradicate a sometimes very expensive recalc right out of the hot path.
/cc my partners in crime @AdamShwert, @alondahari, @arelia, @camchenry, @ctmayn, @Cbodfield, @dgreif, @jibrang, @francinelucca
Screenshots
Integration
List the issues that this change affects.
Closes # (type the GitHub issue number after #)
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.