Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop raising error if CSS classes are used instead of system arguments #3219

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

Currently, an error is raised in dev if a user tries to add a utility class manually via the classes: argument instead of via system arguments. We're running into the error while trying to add a new utility class. The reasons for forcing system arguments are not as strong as they once were (see (internal-only): https://github.slack.com/archives/CGJTTJ738/p1704220474337609), so we've elected to stop raising the error.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I un-reverted @jonrohan's original PR: #2477

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: f52f439

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 4, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@camertron camertron marked this pull request as ready for review December 4, 2024 23:50
@camertron camertron requested review from a team as code owners December 4, 2024 23:50
@jonrohan jonrohan merged commit 633bd05 into main Dec 5, 2024
34 checks passed
@jonrohan jonrohan deleted the remove_classify_error branch December 5, 2024 01:51
@primer primer bot mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants